feat(nuxt): Instrument Database #17899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logaretm
force-pushed
the
awad/js-1036-nuxtnitro-instrument-database-sqlite
branch
4 times, most recently
from
7f29d2e to
55ca147
Compare
logaretm
changed the base branch from
develop
to
awad/js-1023-nuxtnitro-instrument-cache
logaretm
force-pushed
the
awad/js-1023-nuxtnitro-instrument-cache
branch
from
c844c9e to
17482e2
Compare
logaretm
force-pushed
the
awad/js-1036-nuxtnitro-instrument-database-sqlite
branch
from
55ca147 to
76ad329
Compare
size-limit report 📦
|
logaretm
force-pushed
the
awad/js-1023-nuxtnitro-instrument-cache
branch
from
17482e2 to
65277c7
Compare
logaretm
force-pushed
the
awad/js-1036-nuxtnitro-instrument-database-sqlite
branch
from
68758a1 to
9599b1d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Sigrid Huemer <[email protected]>
logaretm
force-pushed
the
awad/js-1023-nuxtnitro-instrument-cache
branch
from
65277c7 to
604de80
Compare
logaretm
force-pushed
the
awad/js-1036-nuxtnitro-instrument-database-sqlite
branch
from
7c1e749 to
f9dcb00
Compare
s1gr1d
approved these changes
Oct 16, 2025
| */ | ||
| export default defineNitroPlugin(() => { | ||
| try { | ||
| debug.log('@sentry/nuxt: Instrumenting databases...'); |
There was a problem hiding this comment.
Please add conditionals to the debug.log statements so they are only shown in debug mode. And I think the log already includes [Sentry] at the start (but not 100%) so we could just simplify it so it shows something like this in the end: [Sentry] [Nitro Database Plugin]: Instrumenting databases...
There was a problem hiding this comment.
Forget the note about conditionally calling it. debug already handles that
https://github.com/getsentry/sentry-javascript/pull/17858/files#r2418913504
There was a problem hiding this comment.
I updated the messages, and I think we cleared debug.log being safe to use directly since it does the check on its own.
| for (const instance of databaseInstances) { | ||
| debug.log('@sentry/nuxt: Instrumenting database instance:', instance); | ||
| const db = useDatabase(instance); | ||
| instrumentDatabase(db); |
There was a problem hiding this comment.
I think this only runs once. But if it doesn't: Maybe we need a conditional here to check whether the database was already instrumented.
logaretm
force-pushed
the
awad/js-1023-nuxtnitro-instrument-cache
branch
from
604de80 to
f1dd874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces automatic instrumentation for database queries in Nuxt applications in server side handlers using Sentry.
Implementation Details
.sql,.prepareand.execcalls.This relies on the work done in #17858 and #17886